Re: bugfix - contrib/pgbench

From: Neil Conway <neilc(at)samurai(dot)com>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: bugfix - contrib/pgbench
Date: 2005-05-23 05:37:53
Message-ID: 42916C31.6010505@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

ITAGAKI Takahiro wrote:
> --- 622,628 ----
> for (i = 0; i < (sizeof(DDLAFTERs) / sizeof(char *)); i++)
> {
> res = PQexec(con, DDLAFTERs[i]);
> ! if (strncmp(DDLAFTERs[i], "drop", 4) && PQresultStatus(res) != PGRES_COMMAND_OK)
> {
> fprintf(stderr, "%s", PQerrorMessage(con));
> exit(1);

None of the DDL in DDLAFTERs begins with "drop", so ISTM the right fix
is to just remove the strncmp().

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2005-05-23 07:43:44 Re: bugfix - contrib/pgbench
Previous Message Nigel Kukard 2005-05-23 05:28:08 unsubscribe