Re: [PATCH] Appbundle-Support for 1.2

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
Cc: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Appbundle-Support for 1.2
Date: 2005-05-14 00:31:42
Message-ID: 428546EE.9060508@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Raphaël Enrici wrote:
> Dave Page wrote:
>>>From: blacknoz(at)club-internet(dot)fr [mailto:blacknoz(at)club-internet(dot)fr]
>>>
>>>Hi Dave, Florian,
>>>
>>>I just took a quick look to the patch provided by Florian. I
>>>didn't try the build yet and I may be wrong, but to me it
>>>does not handle the "DESTDIR" problem and refers to PREFIX,
>>>not DESTDIR.
>>>However, I'll try that tonight. Florian, can you confirm you
>>>were referring to DESTDIR and not PREFIX ?
>>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
>>
>>Gmake/automake/autoconf is all black magic for me, hence why I'd rather
>>tackle one problem on on OS (that I don't have) at a time :-)
>
> So, let's continue the twist :)
>
> attached is the patch that works for me and keeps what was added by
> Florian. As I understand it, $(PREFIX) is the equivalent to "my"
> $(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
> replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref from Makefile.am.
>
> Florian, what do you think about it?

Dave, please apply Rapahels correction of my patch - I was just being
brain-dead ;-)

I meant to write "$(DESTDIR)" - but somehow I ended up typing
"$(PREFIX)", and didn't notice because $(PREFIX) is undefined,
and this empty.

Sorry for the confusion

greetings, Florian Pflug

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Raphaël Enrici 2005-05-15 20:27:41 Re: [PATCH] Appbundle-Support for 1.2
Previous Message Raphaël Enrici 2005-05-13 21:52:03 [PATCH] acinclude.m4