| From: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net> |
| Subject: | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Date: | 2021-01-13 13:39:40 |
| Message-ID: | 42816383349a44e95558875a0962a0a8@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-01-13 14:34, Michael Paquier wrote:
> On Wed, Jan 13, 2021 at 05:22:49PM +0900, Michael Paquier wrote:
>> Yeah, that makes sense. I'll send an updated patch based on that.
>
> And here you go as per the attached. I don't think that there was
> anything remaining on my radar. This version still needs to be
> indented properly though.
>
> Thoughts?
>
Thanks.
+ bits32 options; /* bitmask of CLUSTEROPT_* */
This should say '/* bitmask of CLUOPT_* */', I guess, since there are
only CLUOPT's defined. Otherwise, everything looks as per discussed
upthread.
By the way, something went wrong with the last email subject, so I have
changed it back to the original in this response. I also attached your
patch (with only this CLUOPT_* correction) to keep it in the thread for
sure. Although, postgresql.org's web archive is clever enough to link
your email to the same thread even with different subject.
Regards
--
Alexey Kondratov
Postgres Professional https://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| refactor-utility-opts-michael-6.patch | text/x-diff | 30.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-01-13 13:51:35 | Re: outdated references to replication timeout |
| Previous Message | Daniel Gustafsson | 2021-01-13 13:23:26 | Re: remove unneeded pstrdup in fetch_table_list |