| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, Jan Wieck <JanWieck(at)Yahoo(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Added columns to pg_stat_activity |
| Date: | 2005-05-09 11:33:48 |
| Message-ID: | 427F4A9C.3040303@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> If the stats collector gets sufficiently backed up, you will lose
> messages. [...] Please do not try to make piecemeal changes in that
> basic design decision.
Fair enough.
> (Actually, we could skinny it down to backend PID only ...
> but that would add a hashtable lookup to every message reception in
> the stats collector, instead of just indexing into a BackendId array,
> so it'd probably be a net loss.)
Yeah, I agree -- backend ID and database ID isn't too bad.
I've applied Magnus patch and bumped the catalog version. I'll take a
look at reorganizing the statistics collector so that the message header
is smaller shortly.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2005-05-09 15:27:04 | Re: Added columns to pg_stat_activity |
| Previous Message | Magnus Hagander | 2005-05-09 10:35:09 | Updated kerberos service name patch |