Re: Bug in ILIKE?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Bug in ILIKE?
Date: 2008-09-26 22:58:58
Message-ID: 427.1222469938@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> I think it's just a bug in 8.3.

> Well, here's a patch that I think fixes it. If you're happy I'll apply
> it to HEAD and 8.3.

That patch isn't gonna apply to HEAD ;-). Also the introduction of
NextChar is simply broken, as it will skip additional bytes of a
multibyte char without having compared 'em. All you need AFAICS is
to put TCHAR()s into the *p != *t comparison, so that it matches the
case for ordinary characters.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Browne 2008-09-26 23:08:57 Re: PostgreSQL future ideas
Previous Message Andrew Dunstan 2008-09-26 22:42:57 Re: Bug in ILIKE?