Re: Calculation of param_source_rels in add_paths_to_joinrel

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Calculation of param_source_rels in add_paths_to_joinrel
Date: 2016-11-23 21:28:18
Message-ID: 426.1479936498@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
> On Sat, Nov 5, 2016 at 2:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
>>> Also, the way this code has been written, the declaration of variable
>>> sjinfo masks the earlier declaration with the same name.

>> Hmm, yeah, that's probably not terribly good coding practice.

> Attached a patch to fix this.

Pushed, sorry about the delay.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-11-23 22:04:54 Re: DROP FUNCTION of multiple functions
Previous Message Thomas Munro 2016-11-23 21:19:37 Re: DISTINCT with btree skip scan