| From: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
|---|---|
| To: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Show 'Rows Removed by Filter' with two fractional digits in EXPLAIN |
| Date: | 2026-11-10 11:35:16 |
| Message-ID: | 424db487-e971-4acc-bd2f-539c688b9e76@tantorlabs.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/10/26 13:33, Andrei Lepikhov wrote:
> On 10/11/2026 08:12, Ilia Evdokimov wrote:
>> On 11/10/26 01:59, Andrei Lepikhov wrote:
>>
>>> Here's the next version of the patch. It passed 'make check-world' on the
>>> current master (c074737f687).
>> One small nit: could we also use a precision of 2 in the else branch of `nloops
>>> 0`, so that it prints 0.00 rather than 0? Looking at the changes in [0], its
>> parser will accept both integer and fractional values, so this suggestion is
>> mainly for consistency.
> I doubt that. What you want is the never-executed, non-text format case. In this
> case, I see the following:
>
> "Actual Rows": 0,
>
> To ensure, I checked it on the current master with the query:
>
> explain (analyze, costs off, timing off, summary off, buffers off, format json)
> select * from
> generate_series(1,0) g, lateral
> (select * from pg_class c
> where c.relpages + g > 0
> offset 0
> ) s;
>
> So, as I understand it, adding floating-point to the 'else' section causes
> inconsistency with the 'Actual Rows' format. Am I wrong?
>
You're right, I overlooked the never-executed case for Actual Rows.
Thanks for checking!
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Nidzwetzki | 2026-11-10 12:10:50 | Re: improving handling of FPIs during recovery prefetching |
| Previous Message | David Geier | 2026-11-10 11:01:43 | Re: Reduce build times of pg_trgm GIN indexes |