| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Cc: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
| Subject: | Re: [HACKERS] contrib/pg_buffercache |
| Date: | 2005-03-30 19:40:11 |
| Message-ID: | 424B009B.50307@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
cheers
andrew
Andrew Dunstan wrote:
>It fixes the build error on Windows - haven't tried because i don't have
>time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
>defined on Cygwin - see previous almost endless discussions.
>
>cheers
>
>andrew
>
>Mark Kirkwood wrote:
>
>
>
>>Andrew Dunstan wrote:
>>
>>
>>
>>>... is apparently broken for Windows and Cygwin. See for example
>>>http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=loris&dt=2005-03-16%2001:55:33
>>>
>>>
>>>
>>>
>>Andrew,
>>
>>The attached patch seems to sort it for me, can you give it try on
>>win32 and cygwin?
>>
>>cheers
>>
>>Mark
>>
>>
>>
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| buffercache.patch | text/x-patch | 743 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2005-03-30 19:43:23 | Re: Patch for collation using ICU |
| Previous Message | Peter Eisentraut | 2005-03-30 19:37:34 | Re: Patch for collation using ICU |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2005-03-31 00:45:47 | Re: [HACKERS] contrib/pg_buffercache |
| Previous Message | Alvaro Herrera | 2005-03-30 14:56:10 | Re: unused variable ShmemBootstrap |