Re: contrib/pg_buffercache

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: contrib/pg_buffercache
Date: 2005-03-16 16:23:08
Message-ID: 42385D6C.9050806@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


It fixes the build error on Windows - haven't tried because i don't have
time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
defined on Cygwin - see previous almost endless discussions.

cheers

andrew

Mark Kirkwood wrote:

> Andrew Dunstan wrote:
>
>> ... is apparently broken for Windows and Cygwin. See for example
>> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=loris&dt=2005-03-16%2001:55:33
>>
>>
>
> Andrew,
>
> The attached patch seems to sort it for me, can you give it try on
> win32 and cygwin?
>
> cheers
>
> Mark
>
>------------------------------------------------------------------------
>
>--- pg_buffercache_pages.c.orig Sun Mar 13 04:36:24 2005
>+++ pg_buffercache_pages.c Wed Mar 16 20:57:52 2005
>@@ -17,6 +17,11 @@
>
> #define NUM_BUFFERCACHE_PAGES_ELEM 6
>
>+#ifdef WIN32
>+extern DLLIMPORT BufferDesc *BufferDescriptors;
>+extern DLLIMPORT volatile uint32 InterruptHoldoffCount;
>+#endif
>+
>
> /*
> * Record structure holding the to be exposed cache data.
>
>
>------------------------------------------------------------------------
>
>
>---------------------------(end of broadcast)---------------------------
>TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Hallgren 2005-03-16 18:35:57 Savepoints and SPI
Previous Message David Pradier 2005-03-16 16:14:32 Re: Erratic error message "ERROR: column "id_compte" does

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-03-16 21:28:07 Re: [PATCHES] [pgsql-hackers-win32] snprintf causes regression
Previous Message Christof Petig 2005-03-16 15:30:00 Re: [INTERFACES] libecpg (8.0 and CVS) hits a gcc bug on powerpc