Re: postgres_fdw bug in 9.6

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw bug in 9.6
Date: 2017-04-04 09:01:36
Message-ID: 424933d7-d6bb-4b8f-4e44-1fea212af083@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2017/04/04 14:38, Ashutosh Bapat wrote:
> Probably we should use "could not be created" instead of "was not
> created" in "... a local path suitable for EPQ checks was not created".

Done.

> "outer_path should not require relations from inner_path" may be
> reworded as "outer paths should not be parameterized by the inner
> relations".
>
> "neither path should require relations from the other path" may be
> reworded as "neither path should be parameterized by the the other
> joining relation".

Done. I used "input" instead of "joining" in the latter, though.

> Why JOIN_RIGHT is being treated differently from JOIN_LEFT? We
> should be able
> to create a nested loop join for JOIN_RIGHT?
> + case JOIN_RIGHT:
> + case JOIN_FULL:
>
>
> I don't think so, because nestloop joins aren't supported for
> JOIN_RIGHT. See ExecInitNestLoop().
>
>
> Hmm, I see in match_unsorted_outer()
> 1254 case JOIN_RIGHT:
> 1255 case JOIN_FULL:
> 1256 nestjoinOK = false;
> 1257 useallclauses = true;
> 1258 break;

Yeah, I should have pointed that out as well.

I rebased the patch also. Please find attached an updated version of
the patch.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
epqpath-for-foreignjoin-8.patch text/x-patch 46.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-04-04 09:26:58 Re: Some never executed code regarding the table sync worker
Previous Message Amit Langote 2017-04-04 08:57:54 Re: ANALYZE command progress checker