| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ALTER EXTENSION .. ADD/DROP weirdness |
| Date: | 2011-10-12 22:44:55 |
| Message-ID: | 4247.1318459495@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Hmm. I'm afraid that's going to break something, because I had had it
> like that originally and changed it in commit
> 988cccc620dd8c16d77f88ede167b22056176324. However, I'm not quite sure
> *what* it will break, because it seems like in general extension
> dependencies ought to act pretty nearly like owner dependencies.
> In a quick look, this seems to be the only place where we're doing it
> differently (without a clear reason) for recordDependencyOnOwner and
> recordDependencyOnCurrentExtension.
After studying the code a bit more, I think I was worrying about some
corner cases involving shell type replacement; but they're not
interesting enough to justify making the main-line cases harder to work
with. So I think this is a good fix, and I applied it with some comment
adjustments.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-10-12 23:07:22 | Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c |
| Previous Message | Alex Hunsaker | 2011-10-12 21:33:30 | Re: pl/perl example in the doc no longer works in 9.1 |