Re: contrib/pg_buffercache

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/pg_buffercache
Date: 2005-03-17 01:20:10
Message-ID: 4238DB4A.6010500@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Mark Kirkwood wrote:

> Andrew Dunstan wrote:
>
>> It fixes the build error on Windows - haven't tried because i don't have
>> time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
>> defined on Cygwin - see previous almost endless discussions.
>>
>
> Yes - I recall that discussion a while ago.
>
> This patch should sort the issue.
>
> One question, should I be using defined(__MINGW32__) as opposed to
> defined(WIN32)? I figured I didn't as in this case it is not necessary
> to distinguish between native and cygwin.
>
>

You figured correctly.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Kirkwood 2005-03-17 02:53:18 Re: contrib/pg_buffercache
Previous Message Mark Kirkwood 2005-03-17 00:47:20 Re: contrib/pg_buffercache

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2005-03-17 02:53:18 Re: contrib/pg_buffercache
Previous Message Mark Kirkwood 2005-03-17 00:47:20 Re: contrib/pg_buffercache