Re: ALTER FUNCTION / STRICT

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: ALTER FUNCTION / STRICT
Date: 2005-03-13 10:47:06
Message-ID: 42341A2A.2030706@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> You realize of course that that can already be done with CREATE OR
> REPLACE FUNCTION.

Good point; that makes me less wary of breaking dependencies on existing
functions via ALTER, since in any case that can already be done.

>>Incidentally, is there a reason that DROP FUNCTION doesn't use the
>>FuncWithArgs node?
>
> Probably just historical, but why bother changing it?

It's just a small cleanup, but it seems inconsistent to me to have an
abstraction "function name with args" that is only used in some of the
situations where it's applicable. I know, I'm ornery about these things :)

Attached is a revised patch that also allows security definer and
function volatility to be changed. Barring any objections, I'll apply
this tomorrow (I'm going to take a closer look at the patch before
applying it -- there might be a few details I want to polish up...)

-Neil

Attachment Content-Type Size
alter_function_strictness-5.patch text/x-patch 27.0 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2005-03-13 12:40:22 Re: pgcrypto: openssl digest fix
Previous Message Neil Conway 2005-03-13 10:43:02 Re: pgcrypto: openssl digest fix