| From: | Erik Rijkers <er(at)xs4all(dot)nl> |
|---|---|
| To: | 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, 蔡松露(子嘉) <zijia(at)taobao(dot)com>, "Cai, Le" <le(dot)cai(at)alibaba-inc(dot)com>, 萧少聪(铁庵) <shaocong(dot)xsc(at)alibaba-inc(dot)com> |
| Subject: | Re: [Proposal] Global temporary tables |
| Date: | 2020-04-07 10:40:33 |
| Message-ID: | 42322fef5b6548b08f8d58ebea373883@xs4all.nl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-04-07 10:57, 曾文旌 wrote:
> [global_temporary_table_v24-pg13.patch ]
Hi,
With gcc 9.3.0 (debian stretch), I see some low-key protests during the
build:
index.c: In function ‘index_drop’:
index.c:2051:8: warning: variable ‘rel_persistence’ set but not used
[-Wunused-but-set-variable]
2051 | char rel_persistence;
| ^~~~~~~~~~~~~~~
storage_gtt.c: In function ‘gtt_force_enable_index’:
storage_gtt.c:1252:6: warning: unused variable ‘indexOid’
[-Wunused-variable]
1252 | Oid indexOid = RelationGetRelid(index);
| ^~~~~~~~
cluster.c: In function ‘copy_table_data’:
cluster.c:780:2: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
780 | if (RELATION_IS_GLOBAL_TEMP(OldHeap));
| ^~
cluster.c:781:3: note: ...this statement, but the latter is misleadingly
indented as if it were guarded by the ‘if’
781 | is_gtt = true;
| ^~~~~~
Erik
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Isaac Morland | 2020-04-07 10:48:59 | Re: proposal \gcsv |
| Previous Message | Jehan-Guillaume de Rorthais | 2020-04-07 10:36:22 | Re: Using the rr debugging tool to debug Postgres |