Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

On 2021/01/18 13:46, Bharath Rupireddy wrote:
> On Mon, Jan 18, 2021 at 9:38 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>> Please review v11 further.
>>
>> Thanks for updating the patch!
>>
>> The patch for postgres_fdw_get_connections() basically looks good to me.
>> So at first I'd like to push it. Attached is the patch that I extracted
>> postgres_fdw_get_connections() part from 0001 patch and tweaked.
>> Thought?
>
> Thanks.
>
> We need to create the loopback3 with user mapping public, otherwise
> the test might become unstable as shown below. Note that loopback and
> loopback2 are not dropped in the test, so no problem with them.
>
> ALTER SERVER loopback OPTIONS (ADD use_remote_estimate 'off');
> DROP SERVER loopback3 CASCADE;
> NOTICE: drop cascades to 2 other objects
> -DETAIL: drop cascades to user mapping for postgres on server loopback3
> +DETAIL: drop cascades to user mapping for bharath on server loopback3
>
> Attaching v2 patch for postgres_fdw_get_connections. Please have a look.

Thanks! You're right. I pushed the v2 patch.

> I will post patches for the other function postgres_fdw_disconnect,
> GUC and server level option later.

Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION