| From: | Dilip kumar <dilip(dot)kumar(at)huawei(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Jan Lentfer <Jan(dot)Lentfer(at)web(dot)de>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] |
| Date: | 2014-07-10 06:57:07 |
| Message-ID: | 4205E661176A124FAF891E0A6BA9135266341DD6@szxeml509-mbs.china.huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07 July 2014 17:55 Rebert Hass Wrote,
>
> On Fri, Jul 4, 2014 at 1:15 AM, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>
> wrote:
> > In attached patch, I have moved pgpipe, piperead functions to
> > src/port/pipe.c
>
> If we want to consider proceeding with this approach, you should
> probably separate this into a refactoring patch that doesn't do
> anything but move code around and a feature patch that applies on top
> of it.
>
> (As to whether this is the right approach, I'm not sure.)
I have done the refactoring of the code.
Two patches are attached
1. vacuumdb_parallel_refactor.patch --> Moved pg_dump, parallel code to port/parallel_utils.c (almost 800 lines are moved to the common code).
2. vacuumdb_parallel_v9 --> Feature changes for vaccumdb parallel (created on top of first patch).
I think by this changes, we are able to address all the concerns we were having related to duplicate code.
Thanks & Regards,
Dilip Kumar
| Attachment | Content-Type | Size |
|---|---|---|
| vacuumdb_parallel_refactor.patch | application/octet-stream | 57.6 KB |
| vacuumdb_parallel_v9.patch | application/octet-stream | 33.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2014-07-10 07:06:37 | Re: IMPORT FOREIGN SCHEMA statement |
| Previous Message | Tomonari Katsumata | 2014-07-10 06:52:05 | proposal: rounding up time value less than its unit. |