| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove nonmeaningful prefixes in PgStat_* fields |
| Date: | 2023-03-23 06:51:37 |
| Message-ID: | 41d123a2-5c67-2c92-6dca-864466989b5b@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 3/23/23 1:09 AM, Michael Paquier wrote:
> On Wed, Mar 22, 2023 at 02:52:23PM -0400, Melanie Plageman wrote:
>> This comment still has the t_ prefix as does the one for tuples_updated
>> and deleted.
>>
>> otherwise, LGTM.
>
> Good catch. pgstat_count_heap_update() has a t_tuples_hot_updated,
> and pgstat_update_heap_dead_tuples() a t_delta_dead_tuples on top of
> the three you have just reported.
>
> I have grepped for all the fields renamed, and nothing else stands
> out. However, my eyes don't have a 100% accuracy, either.
Thank you both for your keen eye! I just did another check too and did not
find more than the ones you've just reported.
Please find attached V3 getting rid of them.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-remove_nonmeaningful_prefixes.patch | text/plain | 24.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-03-23 07:10:34 | Re: Orphaned wait event |
| Previous Message | Amit Kapila | 2023-03-23 06:51:20 | Re: Data is copied twice when specifying both child and parent table in publication |