Skip site navigation (1) Skip section navigation (2)

Re: sparse (static analyzer) report

From: Neil Conway <neilc(at)samurai(dot)com>
To: Mark Wong <markw(at)osdl(dot)org>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: sparse (static analyzer) report
Date: 2005-01-16 11:21:25
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Mark Wong wrote:
> Ah, so you beat me to it Neil. ;)  Out of curiosity, how much worse
> was it before you started fixing things?

As I recall, not too different than things are today -- sparse flagged a 
bunch of stylistic issues that I fixed, like:

void some_func() { ... } => void some_func(void) { ... }

extern void some_func(void) { ... } => void some_func(void) { ... }

etc. But given that there are 3000 odd warnings (mostly bogus), I doubt 
I made a significant dent on the total warning count.

Also, I don't recall sparse picking up any significant errors or 
problems. As I said, I've been meaning to explore if that's all that 
sparse can do -- I just looked at the lowest of the low-hanging fruit.


In response to

pgsql-hackers by date

Next:From: lsunleyDate: 2005-01-16 17:13:05
Subject: Re: OS/2 port regression tests
Previous:From: Stuart BishopDate: 2005-01-16 06:30:11
Subject: Re: PostgreSQL 8.0.0 Release Candidate 4

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group