Re: sparse (static analyzer) report

From: Neil Conway <neilc(at)samurai(dot)com>
To: Mark Wong <markw(at)osdl(dot)org>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: sparse (static analyzer) report
Date: 2005-01-16 11:21:25
Message-ID: 41EA4E35.6080005@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark Wong wrote:
> Ah, so you beat me to it Neil. ;) Out of curiosity, how much worse
> was it before you started fixing things?

As I recall, not too different than things are today -- sparse flagged a
bunch of stylistic issues that I fixed, like:

void some_func() { ... } => void some_func(void) { ... }

extern void some_func(void) { ... } => void some_func(void) { ... }

etc. But given that there are 3000 odd warnings (mostly bogus), I doubt
I made a significant dent on the total warning count.

Also, I don't recall sparse picking up any significant errors or
problems. As I said, I've been meaning to explore if that's all that
sparse can do -- I just looked at the lowest of the low-hanging fruit.

-Neil

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message lsunley 2005-01-16 17:13:05 Re: OS/2 port regression tests
Previous Message Stuart Bishop 2005-01-16 06:30:11 Re: PostgreSQL 8.0.0 Release Candidate 4