Re: Verbosity of column definition mismatch error

From: Brendan Jurd <blakjak(at)blakjak(dot)sytes(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Verbosity of column definition mismatch error
Date: 2005-01-11 00:02:28
Message-ID: 41E31794.5060006@blakjak.sytes.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

>Brendan Jurd <blakjak(at)blakjak(dot)sytes(dot)net> writes:
>
>
>>ERROR: query-specified return row and actual function return row do not
>>match
>>
>>
>
>
>
>>With that in mind, I'd like to submit a request, that the verbosity of
>>this error message be increased to explain which ordinal column position
>>the error occurred at, and, if possible, the details of the mismatch.
>>
>>
>
>This is a fairly trivial change, but unfortunately it's too late for
>8.0, because we froze error message texts some time ago (for the benefit
>of translators).
>
>If you want to start working on a patch for 8.1, look in
>src/backend/executor/nodeFunctionscan.c. I'd be inclined to forget the
>bool return convention for tupledesc_match() and just have it ereport
>directly when it sees a problem. The rowtype matching code in
>check_sql_fn_retval (in src/backend/executor/functions.c) would be
>useful as a reference.
>
> regards, tom lane
>
>---------------------------(end of broadcast)---------------------------
>TIP 4: Don't 'kill -9' the postmaster
>
>
I'll check it out. Thanks for the pointers.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-01-11 02:46:00 tsearch2 portability bug
Previous Message Tom Lane 2005-01-10 23:42:43 Re: Verbosity of column definition mismatch error