| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: refactoring relation extension and BufferAlloc(), faster COPY |
| Date: | 2023-02-10 16:38:50 |
| Message-ID: | 419312fd-9255-078c-c3e3-f0525f911d7f@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I'll continue reviewing this, but here's some feedback on the first two
patches:
v2-0001-aio-Add-some-error-checking-around-pinning.patch:
I wonder if the extra assertion in LockBufHdr() is worth the overhead.
It won't add anything without assertions, of course, but still. No
objections if you think it's worth it.
v2-0002-hio-Release-extension-lock-before-initializing-pa.patch:
Looks as far as it goes. It's a bit silly that we use RBM_ZERO_AND_LOCK,
which zeroes the page, and then we call PageInit to zero the page again.
RBM_ZERO_AND_LOCK only zeroes the page if it wasn't in the buffer cache
previously, but with P_NEW, that is always true.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-02-10 17:53:58 | Re: ICU locale validation / canonicalization |
| Previous Message | vignesh C | 2023-02-10 16:31:24 | Re: Support logical replication of DDLs |