| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This |
| Date: | 2011-11-26 07:13:09 |
| Message-ID: | 4174.1322291589@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Modify pg_dump to use error-free memory allocation macros. This avoids
> ignoring errors and call-site error checking.
This appears to have broken the MSVC build. More generally, I'd like to
object to arbitrarily moving a bunch of longstanding code from one file
to another. What that is mainly going to accomplish is creating a big
headache whenever we have to back-patch fixes that touch that code
... and what exactly did it buy in return?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2011-11-26 10:16:41 | pgsql: Take fillfactor into account in the new COPY bulk heap insert co |
| Previous Message | Jaime Casanova | 2011-11-26 04:09:09 | Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2011-11-26 08:51:17 | patch: CHECK FUNCTION statement |
| Previous Message | Jeff Davis | 2011-11-26 07:11:13 | Re: GiST for range types (was Re: Range Types - typo + NULL string constructor) |