From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: strange result from contrib/seg regression on windows |
Date: | 2004-10-17 21:44:56 |
Message-ID: | 4172E7D8.1000403@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>Does anyone have a clue why?
>>
>>
>
>Evidently your sscanf isn't setting errno for overflow --- look at
>seg_atof() in segparse.y.
>
>
>This code shows several other signs of severe brain death, actually,
>like leaking 256 bytes on each call for an error message buffer that it
>doesn't even need :-( I'd recommend ripping the whole thing out and
>replacing with a call to float4in.
>
>
>
>
Yeah. If anyone can do this quickly I'd be grateful. Otherwise it will
probably be a few days before I get it done.
Alternatively, could we not just use strtof instead of sscanf?
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Kirkwood | 2004-10-17 21:51:20 | Re: plans for bitmap indexes? |
Previous Message | Tom Lane | 2004-10-17 21:20:40 | Re: Open Items |
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2004-10-18 04:24:12 | additional GCC warning flags |
Previous Message | Devrim GUNDUZ | 2004-10-17 21:15:20 | Re: (Turkish)New translation: pg_config |