Re: more dirmod CYGWIN

From: Reini Urban <rurban(at)x-ray(dot)at>
To:
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: more dirmod CYGWIN
Date: 2004-10-13 12:28:44
Message-ID: 416D1F7C.7060809@x-ray.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian schrieb:
> I have added the attached patch to allow Cygwin /contrib compiles. I am
> a little confused why Cygwin requires -lpgport and no other platform
> does, but it is in the Cygwin-specific section so we can always improve
> it later if we find the cause.

thanks. duplicate does not harm.
I tell you when I'll find the real culprit.
I thought I knew it last month, but the LDFLAGS / LIBS issue
(adding all libs to LDFLAGS) is already fixed now.

> Index: src/Makefile.shlib
> ===================================================================
> RCS file: /cvsroot/pgsql/src/Makefile.shlib,v
> retrieving revision 1.83
> diff -c -c -r1.83 Makefile.shlib
> *** src/Makefile.shlib 13 Oct 2004 09:51:47 -0000 1.83
> --- src/Makefile.shlib 13 Oct 2004 10:17:36 -0000
> ***************
> *** 216,221 ****
> --- 216,223 ----
>
> ifeq ($(PORTNAME), cygwin)
> shlib = $(NAME)$(DLSUFFIX)
> + # needed for /contrib modules, not sure why
> + SHLIB_LINK += -lpgport
> endif
>
> ifeq ($(PORTNAME), win32)

--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-13 14:19:50 Re: plans for bitmap indexes?
Previous Message Reini Urban 2004-10-13 12:21:09 Re: plans for bitmap indexes?

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Jean-Marc EBER 2004-10-14 07:28:26 Re: building and linking C user defined functions
Previous Message Dave Page 2004-10-13 11:59:42 Re: [pgsql-hackers-win32] Static build of libpq fails

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2004-10-13 13:49:08 Re: pg_restore - added documentation
Previous Message Dave Page 2004-10-13 11:59:42 Re: [pgsql-hackers-win32] Static build of libpq fails