minor code cleanup

From: Neil Conway <neilc(at)samurai(dot)com>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: minor code cleanup
Date: 2004-10-09 12:08:54
Message-ID: 4167D4D6.3050908@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The attached patch makes the following cosmetic improvements:

- replace some function signatures of the form "some_type foo()" with
"some_type foo(void)"
- replace a few instances of a literal 0 being used as a NULL pointer;
there are more instances of this in the code, but I just fixed a few
- in src/backend/utils/mb/wstrncmp.c, replace K&R style function
declarations with ANSI style, remove use of 'register' keyword
- remove an "extern" modifier that was applied to a function definition
(rather than a declaration)

(These changes were made initially to satisfy "sparse", but IMHO they
are all good style anyway.)

Barring any objections, I intend to apply this patch on Sunday or Monday.

-Neil

Attachment Content-Type Size
sparse-cleanup-3.patch text/plain 10.2 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Reini Urban 2004-10-09 13:41:18 cypg.dll, libpq_a, initdb max_connections 60
Previous Message Heikki Linnakangas 2004-10-09 11:48:09 Two-phase commit patch updated