From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Michael Paesold <mpaesold(at)gmx(dot)at>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Log line prefix on win32 |
Date: | 2004-10-08 17:40:08 |
Message-ID: | 4166D0F8.50808@pse-consulting.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>
>>I was thinking of adding %z as an option to log_line prefix, so to get
>>the current output you would do '%t %z'. I was not suggesting changing
>>the %Z passed to strftime if they ask for timezone.
>
>
> I think this is a bad idea, mainly because you couldn't easily get the
> same output. It would be almost the same, except when you crossed a DST
> boundary in between the two calls to strftime; in which case you'd get a
> completely misleading result.
>
> I believe that in the long run we will stop using the platform-specific
> strftime at all, and go over to using just our own code, which makes
> this not a permanent problem but just an artifact of the fact that we
> haven't completely finished the process of absorbing src/timezone/.
> So I'd rather not invent an API element simply because Windows' strftime
> sucks.
However tz is implemented, I'd like to see a log_line_prefix option
which simply omits the TZ, which is noise for me.
Regards,
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-10-08 17:53:35 | Re: Log line prefix on win32 |
Previous Message | Bruce Momjian | 2004-10-08 17:38:06 | Re: Log line prefix on win32 |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-10-08 17:53:35 | Re: Log line prefix on win32 |
Previous Message | Bruce Momjian | 2004-10-08 17:38:06 | Re: Log line prefix on win32 |