Re: pgsql: Use signals for postmaster death on Linux.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use signals for postmaster death on Linux.
Date: 2018-08-01 20:07:54
Message-ID: 4166.1533154074@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thomas Munro <tmunro(at)postgresql(dot)org> writes:
> Use signals for postmaster death on Linux.

One or the other of these patches seems to have caused pmsignal.h
to fail to compile standalone:

./src/include/storage/pmsignal.h:79: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'postmaster_possibly_dead'
./src/include/storage/pmsignal.h: In function 'PostmasterIsAlive':
./src/include/storage/pmsignal.h:84: error: 'postmaster_possibly_dead' undeclared (first use in this function)
./src/include/storage/pmsignal.h:84: error: (Each undeclared identifier is reported only once
./src/include/storage/pmsignal.h:84: error: for each function it appears in.)

Apparently, this header needs a reference to wherever sig_atomic_t
is declared.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-08-01 20:38:08 pgsql: Fix per-tuple memory leak in partition tuple routing
Previous Message Tom Lane 2018-08-01 16:31:01 pgsql: Fix libpq's code for searching .pgpass; rationalize empty-list-i