From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Clean up ancient test style |
Date: | 2020-12-11 17:22:55 |
Message-ID: | 4165763.1607707375@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> Many older tests where written in a style like
> SELECT '' AS two, i.* FROM INT2_TBL ...
> where the first column indicated the number of expected result rows.
> This has gotten increasingly out of date, as the test data fixtures
> have expanded, so a lot of these don't match anymore and are misleading.
> Moreover, this style isn't really necessary, since the psql output
> already shows the number of result rows. (Perhaps this was different at
> some point?)
> I'm proposing to clean all this up by removing all those extra columns.
+1 for concept ... I didn't bother to check the patch in detail.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2020-12-11 17:23:10 | Re: pg_basebackup test coverage |
Previous Message | Tom Lane | 2020-12-11 17:21:17 | Rethinking plpgsql's assignment implementation |