From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: convert libpq uri-regress tests to tap test |
Date: | 2022-03-01 15:52:43 |
Message-ID: | 415675D7-0D06-4712-9CD5-397377671273@anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On March 1, 2022 7:44:27 AM PST, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>On 2/24/22 07:19, Andrew Dunstan wrote:
>> On 2/23/22 20:52, Tom Lane wrote:
>>> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>>>> On 23.02.22 23:58, Tom Lane wrote:
>>>>> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>>>>>> libpq TAP tests should be in src/interfaces/libpq/t/.
>>>>> That's failing to account for the fact that a libpq test can't
>>>>> really be a pure-perl TAP test; you need some C code to drive the
>>>>> library.
>>>> Such things could be put under src/interfaces/libpq/test, or some other
>>>> subdirectory. We already have src/interfaces/ecpg/test.
>>> OK, but then the TAP scripts are under src/interfaces/libpq/test/t,
>>> which isn't what you said. I have no great objection to moving
>>> src/test/modules/libpq_pipeline/ to src/interfaces/libpq/test/,
>>> though, as long as the buildfarm will cope.
>>>
>>>
>>
>> It won't without some adjustment.
>
>
>
>See
><https://github.com/PGBuildFarm/client-code/commit/ffc0fc029877632e9437af51bd99ace308daf0c8>
>and
><https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2022-03-01%2010%3A47%3A22&stg=module-libpq-check>
Thanks!
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
From | Date | Subject | |
---|---|---|---|
Next Message | Chapman Flack | 2022-03-01 16:09:13 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |
Previous Message | Andrew Dunstan | 2022-03-01 15:44:27 | Re: convert libpq uri-regress tests to tap test |