Re: arrayfuncs: fix read of uninitialized mem

From: Joe Conway <mail(at)joeconway(dot)com>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: arrayfuncs: fix read of uninitialized mem
Date: 2004-09-15 17:32:08
Message-ID: 41487C98.4070502@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway wrote:
>
> Barring any objections, I'll apply the patch within 24 hours.
>

> ***************
> *** 965,978 ****
> * (including any overhead such as escaping backslashes), and detect
> * whether each item needs double quotes.
> */
> ! values = (char **) palloc(nitems * sizeof(char *));
> ! needquotes = (bool *) palloc(nitems * sizeof(bool));

> --- 965,978 ----
> * (including any overhead such as escaping backslashes), and detect
> * whether each item needs double quotes.
> */
> ! values = (char **) palloc(nitems * sizeof(*values));
> ! needquotes = (bool *) palloc(nitems * sizeof(*needquotes));

Personally I prefer the original style here. And I agree with Tom's
nearby comments. But otherwise looks good to me.

Joe

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2004-09-15 20:44:46 Re: x86_64 configure problem
Previous Message Devrim GUNDUZ 2004-09-15 16:42:11 Turkish translation of initdb.pot