Re: [PATCHES] 8.0.0b1: configure.in cygipc

From: Reini Urban <rurban(at)x-ray(dot)at>
To: pgsql-cygwin(at)postgresql(dot)org
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] 8.0.0b1: configure.in cygipc
Date: 2004-08-26 13:09:18
Message-ID: 412DE0FE.9060104@x-ray.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-patches

Peter Eisentraut schrieb:
> Reini Urban wrote:
>> cygipc is deprecated in cygwin, replaced by cygserver
>> added test to check for running cygserver and the required
>> server in $CYGWIN. Otherwise build for cygipc, but print a
>>warning.
>
> configure checks the build environment, not the run time environment.
> It's completely irrelevant whether cygserver is running when building
> PostgreSQL.

I know, but I didn't want to indroduce yet another --with-cygipc
configure switch, and the run-time detection is just decent a helper.
But my patch is still valid:
The current cygipc check is wrong when cygserver is running. If
cygserver is not running, it displays a warning when using the cygipc
library.

Later we really should check the cygwin release version and decide on
that. That will require `uname -r` parsing.
Ok?
--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Jason Tishler 2004-08-26 16:29:53 Re: postgresql-7.4.5-1 ready for review
Previous Message Peter Eisentraut 2004-08-26 12:55:43 Re: [PATCHES] 8.0.0b1: configure.in cygipc

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2004-08-26 14:17:25 Re: postmaster.pid
Previous Message Peter Eisentraut 2004-08-26 12:55:43 Re: [PATCHES] 8.0.0b1: configure.in cygipc