Re: log_line_prefix additions

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Ed L(dot)" <pgsql(at)bluepolka(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: log_line_prefix additions
Date: 2004-08-25 22:25:49
Message-ID: 412D11ED.20401@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Ed L. wrote:

>Attached also is a patch to comments in sample postgresql.conf file.
>
>Subject: [PATCHES] log_line_prefix additions
>Date: Wednesday August 25 2004 3:26
>From: "Ed L." <pgsql(at)bluepolka(dot)net>
>To: pgsql-patches(at)postgresql(dot)org
>
>This patch against 8.0.0beta1 source adds log_line_prefix options for
>millisecond timestamps (%m), remote host (%h), and remote port (%P). The
>milliseconds are useful for QPS measurements, and the remote port is
>worthless to us as part of %r.
>
>
>
[snip]

>+ struct timezone tz = {0, 0};
>+
>+ gettimeofday(&tv, &tz);
>
>
>

The timezone is pointless. Just pass NULL as the second argument to
gettimeofday().

Also, I don't understand what you mean by the remote port being
"worthless to us as part of %r." Please explain.

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-08-25 22:44:33 Re: add hint
Previous Message James William Pye 2004-08-25 22:24:16 Re: add hint