Re: Wrong results from join removal with DISTINCT ON + SRF subquery

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong results from join removal with DISTINCT ON + SRF subquery
Date: 2026-08-22 01:15:52
Message-ID: 4122160.1787361352@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> Attached is a patch to not rely on DISTINCT ON for distinctness if
> there are any tlist SRFs. This is more conservative than necessary,
> since the SRFs are only postponed when there is an ORDER BY and none
> of them is in a sort/group column, but I don't think it's worth
> duplicating that logic in analyzejoins.c.

I didn't study the patch in any detail, but I concur with your
thinking here. SRFs in the tlist are kind of a legacy usage in the
first place, so I don't feel a need to expend lots of effort on
optimizing cases like this.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rithvika Devisetti 2026-08-22 06:04:49 Re: Fix for fragile code in ltree/crc32.c
Previous Message Richard Guo 2026-08-22 01:06:33 Wrong results from join removal with DISTINCT ON + SRF subquery