Re: psql's EDITOR behavior on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavlo Golub <pavlo(dot)golub(at)cybertec(dot)at>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql's EDITOR behavior on Windows
Date: 2019-12-18 15:11:16
Message-ID: 4113.1576681876@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Pavlo Golub <pavlo(dot)golub(at)cybertec(dot)at> writes:
>> I cannot find the reason why EDITOR value on Windows is quoted.

> The comment you quoted explains it: apparently people expect
> paths-with-spaces to work in that value without any manual quoting.

Actually, after digging in the git history and archives, the current
behavior seems to trace back to a discussion on pgsql-hackers on
2004-11-15. The thread linkage in the archives seems rather incomplete,
but it boiled down to this:

https://www.postgresql.org/message-id/9045.1100539151%40sss.pgh.pa.us

ie, the argument that people could handle space-containing paths by
putting double quotes into the environment variable's value is just wrong.
Possibly Microsoft fixed that in the fifteen years since, but I'd want to
see some proof.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2019-12-18 15:14:20 Re: Read Uncommitted
Previous Message Tom Lane 2019-12-18 14:43:12 Re: psql's EDITOR behavior on Windows