| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Use of RangeVar for partitioned tables in autovacuum |
| Date: | 2017-09-27 18:11:27 |
| Message-ID: | 40FE9F7B-E130-4A2C-ABAD-7DF4866C7BF9@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/26/17, 9:28 PM, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com> wrote:
> In conclusion, I think that the open item of $subject should be
> removed from the list, and we should try to get the multi-VACUUM patch
> in to cover any future problems. I'll do so if there are no
> objections.
If someone did want to add logging for vacuum_rel() and analyze_rel() in
v10 after your patch was applied, wouldn't the NULL RangeVars force us to
skip the new log statements for partitions? I think we might instead
want to back-patch the VacuumRelation infrastructure so that we can
appropriately log for partitions.
However, I'm dubious that it is necessary to make such a big change so
close to release for hypothetical log statements. So, in the end, I agree
with you.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-09-27 18:31:56 | Re: Binary search in fmgr_isbuiltin() is a bottleneck. |
| Previous Message | Antonin Houska | 2017-09-27 18:00:28 | Re: WIP: Separate log file for extension |