Re: Fixes for 3 bugs in pg_dump

From: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fixes for 3 bugs in pg_dump
Date: 2004-07-14 07:08:18
Message-ID: 40F4DBE2.6080006@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Actually, i'm not sure that making it respect -S is the right way to go.
What we really need is an option that specifies the cluster owner on
the new installation.

I will revert that part of this patch and resubmit shortly...

Chris

Christopher Kings-Lynne wrote:

> This patch fixes the following bugs:
>
> * pg_dump --clean against a pre-7.3 server output drop commands in the
> form: DROP "".foo; . These will now all be output as: DROP public.foo;
>
> * If you use ALTER USER to set user params on the cluster owner user,
> these would not be dumped. This patch will now dump ALTER USER commands
> for the cluster owner. If the -S command line switch is used to specify
> a superuser, then the cluster owner ALTER USER commands will be dumped
> for that user instead.
>
> * The DateStyle and search_path GUC variables must not be quoted when
> dumped.
>
> Chris
>
>
> ------------------------------------------------------------------------
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2004-07-14 07:15:10 Re: PITR Archive Recovery plus WIP PITR
Previous Message Christopher Kings-Lynne 2004-07-14 06:14:39 Fixes for 3 bugs in pg_dump