Re: logfile rotation

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: logfile rotation
Date: 2004-06-16 19:03:52
Message-ID: 40D09998.7090107@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

>Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>
>
>>>Answering my own question, the distribution of the current logfile
>>>name could be done trough a file handle.
>>>
>>>
>
>
>
>>would you mind commenting on my suggestion so I can continue on that topic?
>>
>>
>
>There is no portable way to redistribute a file handle.
>
>

Seems I didn't make clear enough what I mean.

I'd fopen a file handle in the postmaster, and all subsequent processes
will inherit that handle just as they do for stderr; no redistribution
required.
The log filename is written to that file when pg_logfile_rotate is called:
fseek(fh, 0, SEEK_SET);
fprintf(fh, "%s", newlogfilname);
fflush();

and all subprocesses may retrieve the filename when required by

char buf[MAXPGPATH];
fseek(fh, 0, SEEK_SET);
fread(buf, 1, MAXPGPATH, fh);
buf[MAXPGPATH-1]=0; // prevent buffer overflow
logfile=fopen(buf, "a+");

Regards,
Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-06-16 19:17:53 Re: Tablespaces
Previous Message Andreas Pflug 2004-06-16 18:49:39 Re: Improving postgresql.conf