Re: Compiling libpq with VisualC

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Compiling libpq with VisualC
Date: 2004-06-11 17:51:41
Message-ID: 40C9F12D.5080705@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian wrote:

>
>
>Agreed. My pthread book says pthread_mutex_init() should be called only
>once, and we have to guarantee that. If the Windows implentation allows
>it to be called multiple times, just create a function to be called only
>by Win32 that does that and leave the Unix safe.
>
>
>
Ok, so here's the win32 workaround with the unix stuff left untouched.
There's no memory interlocking api in win32 that wouldn't need some
initializing api call itself, so we'd have to go for assembly level
test-and-set code or introduce a mandatory global libpq initializing
api. Considering the probably quite low usage of kerberos/ssl together
with threads under win32, and the very low probability of two
threads/processors (!) trying to initiate a connection at the same time,
it doesn't seem to be worth the compiler hassle with assembly inline.

Regards,
Andreas

Attachment Content-Type Size
win32-threadsafety.patch text/plain 3.9 KB
pthread-win32.c text/plain 803 bytes
pthread.h.win32 text/plain 410 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2004-06-11 17:58:15 Re: msession for PostgreSQL?
Previous Message Tom Lane 2004-06-11 17:49:18 Re: Accelerating aggregates

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2004-06-11 17:53:22 Re: pg_ctl using START with paths needing quotes
Previous Message Dann Corbit 2004-06-11 17:29:02 Re: [pgsql-hackers-win32] Tablespaces

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-06-11 17:53:22 Re: pg_ctl using START with paths needing quotes
Previous Message Euler Taveira de Oliveira 2004-06-11 17:44:14 Re: translation updates pt_BR