Re: cosmetic psql tweaks

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: cosmetic psql tweaks
Date: 2004-05-24 01:04:36
Message-ID: 40B14A24.60301@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Er, doesn't that change the behavior?

I don't believe so. There is an if statement earlier that assigns
opt->footers to footers is the former is non-NULL. In other words:

if (opt->footers)
footers = opt->footers;
else if (...)
footers = xyz();
else
footers = NULL;

Therefore if footers is NULL then opt->footers must also be NULL, so the
previous trinary statement is just confusing.

-Neil

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-24 02:47:45 Re: pgstat exec cleanup
Previous Message Tom Lane 2004-05-24 00:30:41 Re: cosmetic psql tweaks