Re: pg_ctl patch to integrate apache's rotatelogs

From: Andrew Hammond <ahammond(at)ca(dot)afilias(dot)info>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_ctl patch to integrate apache's rotatelogs
Date: 2004-05-18 13:39:21
Message-ID: 40AA1209.9050801@ca.afilias.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

|>logrotate rotates log files and hups the servers according to a
|>configuration file. rotatelogs reads the log data on stdin and reopens
|>a new output file once in a while. The first hunk of your patch was
|>wrong, the rest seemed OK.
|
|
| OK, just to confirm, I backed out the first attached patch, but kept the
| rest, which is my second attached patch.

This looks correct to me.

| I am still confused how these errors remained in the documentation for
| so long.

Probably because non-syslog logging in a production environment is a
very small niche. Which might, unfortunately, be a good argument against
my proposed patch.

Drew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAqhIGgfzn5SevSpoRAvizAJ0fZRI5o1FuERzUen2ufWwCsz/J2ACghQ7B
agaY+YaC0LIVF/jNCk+QnmA=
=Rsjl
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2004-05-18 13:57:19 Re: Timezone code, one more try
Previous Message Fabien COELHO 2004-05-18 10:44:21 add build utilities in default install