Re: pg_ctl patch to integrate apache's rotatelogs

From: Andrew Hammond <ahammond(at)ca(dot)afilias(dot)info>
To: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: pg_ctl patch to integrate apache's rotatelogs
Date: 2004-05-17 14:20:35
Message-ID: 40A8CA33.3050002@ca.afilias.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Eisentraut wrote:
| Andrew Hammond wrote:
|
|>There was recently a huge thread in hackers about the value of making
|>postgres easier to install and use. I think this script makes
|>postgres easier to use for those of us who can't use syslog.
|
|
| So you're replacing
|
| pg_ctl | rotatelogs
|
| which everyone learns in his first hour of using Unix, by some arbitary
| command-line option that people are going to have to learn.

No, pg_ctl | rotatelogs will still work as well as it did before.
However, for those people who don't _know_ about rotatelogs and are
reading the manual page for pg_ctl, the -r option will point them in the
correct dirrection. On a related note,

pg_ctl > $log_file

has already been replaced by the the arbitrary -l command-line option.
Clearly somebody thought there was some value to be had there and I see
the same sort of value for the -r option.

| Next week, we'll see four or five additional patches to add support
| for all the other log rotation programs.

Personally, I'd see this as a good thing since it helps people try
different tools and pick the one that's right for them. However I doubt
it will happen since the other log rotation tools work differently.
pg_ctl simply doesn't make sense as a place to integrate them.

| Soon, we'll run out of logical option letters. How does that improve
anything?

I thought that was the definition of "feature complete". :)

Drew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAqMovgfzn5SevSpoRAiYeAJ98OpXEPzlFDdIp0LcVBY2nJVsIPwCfbubX
AqSMtU7nxeh+SaNoSDqg1PI=
=aWxW
-----END PGP SIGNATURE-----

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-17 14:41:58 Allow relative path installs
Previous Message Fabien COELHO 2004-05-17 07:33:31 Re: new aggregate functions v1