| From: | "Tels" <nospam-pg-abuse(at)bloodgate(dot)com> |
|---|---|
| To: | "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | "Petr Jelinek" <petr(dot)jelinek(at)2ndquadrant(dot)com>, "Thomas Munro" <thomas(dot)munro(at)enterprisedb(dot)com>, "Vaishnavi Prabakaran" <vaishnaviprabakaran(at)gmail(dot)com>, "Daniel Gustafsson" <daniel(at)yesql(dot)se>, "Peter Eisentraut" <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Noah Misch" <noah(at)leadboat(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Replication status in logical replication |
| Date: | 2017-12-26 09:19:42 |
| Message-ID: | 409e28341e6e32d7f59798d156db9211.squirrel@sm.webmail.pair.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Moin,
On Mon, December 25, 2017 7:26 pm, Masahiko Sawada wrote:
> On Tue, Dec 26, 2017 at 1:10 AM, Petr Jelinek
> <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>> On 21/11/17 22:06, Masahiko Sawada wrote:
>>>
>>> After investigation, I found out that my previous patch was wrong
>>> direction. I should have changed XLogSendLogical() so that we can
>>> check the read LSN and set WalSndCaughtUp = true even after read a
>>> record without wait. Attached updated patch passed 'make check-world'.
>>> Please review it.
>>>
>>
>> Hi,
>>
>> This version looks good to me and seems to be in line with what we do in
>> physical replication.
>>
>> Marking as ready for committer.
(Sorry Masahiko, you'll get this twice, as fumbled the reply button.)
I have not verifed that comment and/or code are correct, just a grammar fix:
+ /*
+ * If we've sent a record is at or beyond the flushed
point, then
+ * we're caught up.
That should read more like this:
"If we've sent a record that is at or beyond the flushed point, we have
caught up."
All the best,
Tels
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2017-12-26 09:37:06 | Re: [HACKERS] [PATCH] Lockable views |
| Previous Message | Kyotaro HORIGUCHI | 2017-12-26 09:19:16 | Re: Protect syscache from bloating with negative cache entries |