Re: Limit eartdistance regression testcase to the public schema

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Limit eartdistance regression testcase to the public schema
Date: 2025-09-26 18:15:59
Message-ID: 4099739.1758910559@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> writes:
> I attached a simple patch to the test case that modifies it to only
> list objects from the public schema. Part of the test case is already
> limited to the public schema, this patch just aligns the rest to do
> the same.

> What do you think?

I think this is breaking the test, because part of the point is
to check that there's not anything installed outside the public
schema (until we tell it to, further down).

Admittedly, this only checks schemas that are in the search_path,
but why do you have other stuff in the search_path? That seems
to cause all kinds of risks of accidentally interfering with
assorted test cases.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-09-26 18:27:34 Re: OAuth client code doesn't work with Google OAuth
Previous Message Filip Janus 2025-09-26 18:13:21 Re: Proposal: Adding compression of temporary files