pavel seleznev <pavel(dot)seleznev(at)gmail(dot)com> writes:
> Hello,
> Should we use the same approach on line 1106 (
> https://github.com/postgres/postgres/blob/c4067383cb2c155c4cfea2351036709e2ebb3535/src/backend/libpq/hba.c#L1106
> )
> as on line 266 (
> https://github.com/postgres/postgres/blob/c4067383cb2c155c4cfea2351036709e2ebb3535/src/backend/tcop/backend_startup.c#L266
> )
> since they reference the same structure?
I see no reason to change either one. BackendInitialize is
explicitly choosing not to run in TopMemoryContext, which is fine,
but that doesn't mean that other code has to do the same.
regards, tom lane