Re: win32 build and test issues

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: win32 build and test issues
Date: 2004-05-02 17:52:57
Message-ID: 40953579.1090002@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches


I have tried very hard to work out why this patch works for the
regression tests in MINGW/MSys, but it doesn't make any sense why this
one call should add an extra blank line. Does anyone have any bright
ideas? I'm reluctant to say I think we should apply it until the problem
is understood and the behaviour explained. But it does appear to work.

cheers

andrew

>>>>Index: print.c
>>>>===================================================================
>>>>RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/print.c,v
>>>>retrieving revision 1.46
>>>>diff -c -w -r1.46 print.c
>>>>*** print.c 24 Jan 2004 20:43:26 -0000 1.46
>>>>--- print.c 30 Apr 2004 16:44:46 -0000
>>>>***************
>>>>*** 388,394 ****
>>>>--- 388,396 ----
>>>> for (ptr = footers; *ptr; ptr++)
>>>> fprintf(fout, "%s\n", *ptr);
>>>>
>>>>+ #ifndef WIN32
>>>> fputc('\n', fout);
>>>>+ #endif
>>>>
>>>> /* clean up */
>>>> free(cell_w);
>>>>
>>>>
>>>>

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Magnus Hagander 2004-05-02 18:07:26 Re: Timezone database questions
Previous Message Bruce Momjian 2004-05-02 12:33:03 regression failures

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-02 18:22:27 Re: win32 build and test issues
Previous Message Fabien COELHO 2004-05-02 15:22:04 new aggregate functions v2