Re: ceiling() and power() (SQL2003)

From: Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: "PostgreSQL-patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: ceiling() and power() (SQL2003)
Date: 2004-05-01 06:04:56
Message-ID: 40933E08.1030701@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil,

Doesn't your patch cause problems with the PostgreSQL ODBC driver which
adds ...

-- CEILING(num)
CREATE OR REPLACE FUNCTION ceiling(numeric) RETURNS numeric AS '
SELECT ceil($1);
' LANGUAGE SQL;

-- POWER(num, num)
CREATE OR REPLACE FUNCTION power(double precision, double precision)
RETURNS double precision AS '
SELECT pow($1, $2);
' LANGUAGE SQL;
CREATE OR REPLACE FUNCTION power(numeric, numeric)
RETURNS numeric AS '
SELECT pow($1, $2);
' LANGUAGE SQL;

On first glance this seems to be same ...

Regards,

Hans

Neil Conway wrote:
> This patch makes the following changes:
>
> (1) Add ceiling() as an alias for ceil() (both double precision and
> numeric variants). This is required by SQL2003, so both spellings of the
> function name have been documented.
>
> (2) Add power() as an alias for pow(). SQL2003 only defines power()
> AFAICS. Rather than documenting two identical spellings of the same
> command, I think it makes sense to migrate toward the spelling that is
> preferred by the standard. Therefore, I renamed the documentation for
> pow() to refer to power().
>
> I didn't remove pow(): that would break far too much existing code, and
> there is little harm in keeping around an additional pg_proc entry or
> two. I think that keeping pow() but not documenting it should ensure
> that new users prefer power() but older applications do not need to be
> changed, which is a reasonable compromise between backward compatibility
> and forward progress.
>
> Regression tests are included (I believe I updated all the variants of
> float8 properly, but please speak up if that is not the case). This
> patch bumps the catalog version number.
>
> Barring any objections, I intend to apply this within 24 hours.
>
> -Neil
>
>
> ------------------------------------------------------------------------
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Cybertec Geschwinde u Schoenig
Schoengrabern 134, A-2020 Hollabrunn, Austria
Tel: +43/2952/30706 or +43/664/233 90 75
www.cybertec.at, www.postgresql.at, kernel.cybertec.at

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-05-01 06:15:18 Re: ceiling() and power() (SQL2003)
Previous Message Tom Lane 2004-05-01 03:45:34 Re: width_bucket() per SQL2003 (WIP)