| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor fixes for upcoming version 13 |
| Date: | 2020-09-09 16:26:28 |
| Message-ID: | 40829.1599668788@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> writes:
> On Wed, Sep 9, 2020 at 12:16 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>> 09.09.2020 18:29, Tom Lane wrote:
>>> But it's not user-visible is it? That should surely be a can't-happen
>>> case.
>> I've encountered this while translating NLS messages in postgres.po and
>> ecpg.po. So I think it should at least puzzle translators.
> Maybe instead Assert(0) with a comment or something like that?
Maybe what we need is yyerror_internal() for messages that don't require
translation. Or just convert it to a plain elog(ERROR) ... that would
lose the possibility of providing an error cursor, but that seems like
something we don't need here either.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-09-09 16:34:48 | Re: Remove line length restriction in passwordFromFile() |
| Previous Message | John Naylor | 2020-09-09 16:20:32 | Re: Minor fixes for upcoming version 13 |