| From: | Greg Stark <gsstark(at)mit(dot)edu> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, jd(at)commandprompt(dot)com, Josh Berkus <josh(at)agliodbs(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stop_backup does not complete |
| Date: | 2010-03-02 13:13:37 |
| Message-ID: | 407d949e1003020513k3a02d1dnb962156adbc7314f@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 2, 2010 at 9:48 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> > Setting archive_mode to a command that does nothing but return true, e.g. /bin/true,
>>
>> "return true" seems ambiguous for me. How about writing clearly
>> "return a zero exit status" instead?
>
> Docs are already quite clear on that point. I think we should avoid
> specifying it twice.
>
Why do we disallow turning off archive_mode anyways? I understand not
turning it on -- though even that would be nice if it "took effect
after the next checkpoint" but turning it off should always be safe,
no?
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2010-03-02 13:19:43 | Re: pg_stop_backup does not complete |
| Previous Message | Oleg Bartunov | 2010-03-02 13:13:07 | building postgres-A4.tex-pdf crushed |