Re: Turn TransactionIdRetreat/Advance into inline functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Turn TransactionIdRetreat/Advance into inline functions
Date: 2022-10-10 14:58:37
Message-ID: 4074409.1665413917@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Maxim Orlov <orlovmg(at)gmail(dot)com> writes:
> I've notice recent activity to convert macros into inline functions. We
> should make TransactionIdRetreat/Advance functions
> Instead of a macro, should we?

-1. Having to touch all the call sites like this outweighs
any claimed advantage: it makes them uglier and it will greatly
complicate any back-patching we might have to do in those areas.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Maxim Orlov 2022-10-10 15:08:20 Re: Turn TransactionIdRetreat/Advance into inline functions
Previous Message Tom Lane 2022-10-10 14:44:41 Re: create subscription - improved warning message