From: | "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: pg_autovacuum patch for 7.4.2 and HEAD |
Date: | 2004-03-13 16:50:02 |
Message-ID: | 40533BBA.1050509@zeut.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
>"Matthew T. O'Connor" <matthew(at)zeut(dot)net> writes:
>
>
>>! new_tbl->relid = atol(PQgetvalue(res, row, PQfnumber(res, "oid")));
>>! new_tbl->reltuples = atof(PQgetvalue(res, row, PQfnumber(res, "reltuples")));
>>! new_tbl->relpages = atol(PQgetvalue(res, row, PQfnumber(res, "relpages")));
>>
>>
>
>This ignores the fact that relid and relpages are unsigned. I would
>suggest adopting the same convention for OID as is used in pg_dump and
>other places:
>
>#define atooid(x) ((Oid) strtoul((x), NULL, 10))
>
>You could actually use this same macro for reading relpages, but that's
>probably abusing the notation. I'd use strtoul directly for relpages,
>I think.
>
>
>
>>! init_dbinfo(char *dbname, int oid, int age)
>>...
>>! init_dbinfo(char *dbname, uint oid, uint age)
>>
>>
>
>This (and other declarations) should be "Oid oid".
>
>
>
Thanks for the help / review. Here is my 2nd cut at fixing this. I
believe I have addressed the above concernes. Please review again and
(hopefully) apply.
Matthew
From | Date | Subject | |
---|---|---|---|
Next Message | Matthew T. O'Connor | 2004-03-13 17:01:51 | Re: pg_autovacuum patch for 7.4.2 and HEAD |
Previous Message | Claudio Natoli | 2004-03-12 23:02:12 | Re: initdb problen |